Credit_Invoice.php in 4.10.1 won't credit

[PakRicard]

Hi:

Just after upgrading from 4.09.1 to 4.10.1 Credit_Invoice will not credit properly.

-Select one customer
-Customer Transactions Inquiry
-Click on credit on any of customer's invoice (with more than 1 item, pls)
-Delete one item from the Credit note

Then the list of items of the credit note appears empty (and it should not be an empty list).

Also the PDF created is an empty page.

Using old 4.09.1 script works fine.

[PakRicard]

Tim just sent me the fix by email. Already updated to SVN.

All credit to Tim.

UPDATE: I was too fast. i've got error commiting via TortoiseSVN, so could not commit the fix.

Line 408 should read

Code:

            <td><a href="' . htmlspecialchars($_SERVER['PHP_SELF'],ENT_QUOTES,'UTF-8') . '?identifier=' . $identifier . '&Delete=' . $LnItm->LineNumber . '" onclick="return confirm(\'' . _('Are you sure you wish to delete this     item from the credit?') . '\');">' . _('Delete') . '</a></td>

[phil]

Thanks guys - I've committed this change now

[PakRicard]

Hi Phil:

After these 2 weeks of test we realized it now does the credit BUT it does not take into account the right location.

If user selects the default credit note type ==> Goods returned to store BUT changes the default location shown, the goods are always returned to the default location, not the desired one.

Never got this bug report from my team, so I suppose was due to the 4.09 to 4.10 change of script.

[MacPhotoBiker]

Hi guys,
please let me use the above example for a more generic question: I´ve seen there was a bug fix now. In general, what´s the best way to get all bug fixes? Probably it´s waiting for the next release, but I was wondering if there was another way.

[phil]

Several ways... you can see the new code committed here:

https://sourceforge.net/p/web-erp/code/commit_browser

You can then download the various updated scripts as required

OR

You can subscribe to the list at

https://lists.sourceforge.net/lists/list...eb-erp-svn

as for every change in the code a message is sent to this list showing what the change was - you can then download the changed files as necessary.

OR

You can subscribe to the svn (Subversion Repository) using Tortoise SVN or similar (assuming you are a windows user.

There is some info at:

http://www.weberp.org/Development.html

and

http://tortoisesvn.net/

If you are using linux then most distros would have an svn client

[MacPhotoBiker]

Phil,
thank you very much, now that is really a valuable source of information. Regarding webERP, I´m usually more interested in the frontend than in the backend, but since I´m running my own VPS web server on a LAMP stack, I just started to dig a bit into PHP. (Interesting you mentioned Linux, I´m just waiting any day now to receive my fancy new "Linux only" laptop, and the SVN client will certainly be one of the first programs I´ll set up )

The longer I use webERP, the more I like it. Sure, there are issues and even one or the other bug (like in any software), but it´s great to see that there is a lively forum, and even more important that you take comments and suggestions into consideration. To me this adds significantly to the usability of the software - and to the fun factor, obviously!

Thanks a lot.

[phil]

Well that's good to here...
Of course the best way to improve the software is to take the feedback from the people using it and build it right back in. It is important to be mindful though of our target market - I don't think for example that we are such a useful system to the SOHO type user - where they need to be able to delete entries etc.
One of the goals I have for webERP is to get business people into the code and I have extended great effort to make it as readable as possible. Hopefully webERP is a good vehicle for learning PHP - I am pretty sure this is where Ricard picked up his now good knowledge and he is foremost (like myself) a business person.

[PakRicard]

Hi Phil:

After these 2 weeks of test we realized it now does the credit BUT it does not take into account the right location.

If user selects the default credit note type ==> Goods returned to store BUT changes the default location shown, the goods are always returned to the default location, not the desired one.

Never got this bug report from my team, so I suppose was due to the 4.09 to 4.10 change of script.

Hi: tried to strip this script but could not find the offending lines. I suppose it should be a wrong variable assignment but couldn't find it.

Any help will be appreciated.

[Exsonqu_Qu]

Hi, Richard:

I've test via the trunk code, but cannot duplicate what you've said. Is it fixed in trunk?

Best regards!

Exson