webERP Forum

Full Version: Lookup field on Product Selection (SelectProduct.php)
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Should not the lookup field (from stockitemproperties) be plain text rather than an input field or dropdown button, as it is not within a form and therefore not updateable?
Yes you are absolutely right - it should be
So now that complete "switch" block can be reduced to this :

$PropValResult = DB_query($sql,$db);
$PropValRow = DB_fetch_row($PropValResult);
$PropertyValue = $PropValRow[0];

if ($PropertyRow['controltype'] == 2) {
if ($PropertyValue == true) $PropertyValue = _('Yes');
else $PropertyValue = _('No');

echo <<<EOT
<th align="left" width="20%">
<td class="select" align="left" colspan=2>
Well I reworked it a bit

    $sql = "SELECT stkcatpropid,
                FROM stockcatproperties
                WHERE categoryid ='" . $myrow['categoryid'] . "'
                AND reqatsalesorder =0
                ORDER BY stkcatpropid";
    $PropertiesResult = DB_query($sql, $db);
    $PropertyCounter = 0;
    $PropertyWidth = array();
    while ($PropertyRow = DB_fetch_array($PropertiesResult)) {
        $PropValResult = DB_query("SELECT value
                                    FROM stockitemproperties
                                    WHERE stockid='" . $StockID . "'
                                    AND stkcatpropid ='" . $PropertyRow['stkcatpropid']."'", $db);
        $PropValRow = DB_fetch_row($PropValResult);
        if (DB_num_rows($PropValResult)==0){
            $PropertyValue = _('Not Set');
        } else {
            $PropertyValue = $PropValRow[0];
        echo '<tr>
                <th align="right">' . $PropertyRow['label'] . ':</th>';
        switch ($PropertyRow['controltype']) {
            case 0:
            case 1:
                echo '<td class="select" style="width:60px">' . $PropertyValue;
            case 2; //checkbox
                echo '<td class="select" style="width:60px">';
                if ($PropertyValue == _('Not Set')){
                    echo _('Not Set');
                } elseif ($PropertyValue == 1){
                    echo _('Yes');
                } else {
                    echo _('No');
        } //end switch
    echo '</td></tr>';
} //end loop round properties for the item category
echo '</table></td>'; //end of Item Category Property mod