RE: "Database Error 1406 CRITICAL" attempting to create invoice
I'm thinking a database change also requires a version change. Is that correct? If so, should changing the reference column size wait until 4.15.3? I'm not familar with the release process, so please advise what the best process would be. E.g. if a release stabilization branch will be created to stabilize 4.15.3 prior to release, I assume I need to wait until the branch is created and then send a pull request for the stabilization branch.
However..... I'm also not clear what code changes are needed to do this. I looked at UpgradeDatabase.php and upgrade4.15.1-4.15.2.sql. Am I correct to understand I would need to update UpgradeDatabase.php and create a new upgrade4.15.2-4.15.3.sql file? Are these the only files involved?
Also I'm thinking the width of debtortrans:reference should be tested first, and only if it is still varchar(20) (the size in the current default.sql), should it be increased to varchar(50). I.e. if the size has been intentionally modified, then it shouldn't be changed. What do you think?
http://www.dalescott.net
|