Update: now have a small testing quirk, maybe?
A test install went well, however, we seem to have lost table
deliverynotes? I noted that my install had 161 tables, before release, but when I reloaded the demo for release, there was only 160 tables.
A diff of
show tables between the two DB's indicated deliverynotes. After test running the zip from the make_release as a fresh install of both weberp and weberpdemo, now both DB's only have 160 tables.
Removal may have been intentional, was removed with
this commit. (line 710) ... but I did also note that there are
NO script query references to the deliverynotes table
acking the code base, so
it appears to be an orphaned table, safely removed?
There was an ALTER to this table in 4.15.1, so just double-checking if we should keep it, or not?
Makes me wonder if we should add a DROP for the deliverynotes table in the upgrade SQL?
Not a big deal, I can create a quick release testing branch to add the drop, if needed, but if not, then I can cover the remainder tomorrow, so please let me know.
I have the other release information staged (the release add/fixed/changed/security brief, and a contributors list ready to go)
I've merged the release branch changes to main, so THAT commit will be the release reference point, unless we add the table drop.
=====
Other than that, back to the chartdetails ... I did not show periods as high as 133.
So what I did was to check the highest period in gltrans (was 62) and the other two tables had periods to 84.
So I removed all records > 62 in periods and chartdetails, and ran the suggested Z_RePost script.
Afterwards, the chartdetails records dropped from ~10k+ to ~7k+, or about a 1/3 reduction.
All seems good on this point.