Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Customer Special Price: expired but still grabbed
10-02-2020, 12:18 AM,
#11
RE: Customer Special Price: expired but still grabbed
Phil, any feedback on the solution I submitted?
Reply
10-02-2020, 10:24 PM,
#12
RE: Customer Special Price: expired but still grabbed
(10-02-2020, 12:18 AM)HDeriauFF Wrote: Phil, any feedback on the solution I submitted?

I have been playing around with this, and have the attached version working (the changes may be the same as yours in which case I apologise).


.php   GetPrice.php (Size: 7.59 KB / Downloads: 2)

This *seems* to work on all scenarios but would appreciate your testing.

A couple of general comments that arose when I looked into this:

1 I thought a decision had been taken a while back to get rid of zero dates as they there are some sql-mode settings in mysql that prohibit them.
2 We should really get rid of all the .inc files and replace them with .php. This was done with some files but not all.

Thanks
Tim
Reply
10-02-2020, 11:49 PM, (This post was last modified: 10-02-2020, 11:50 PM by TurboPT.)
#13
RE: Customer Special Price: expired but still grabbed
I believe that the 0-date aspect was covered. I seem to recall a relative commit, but I'd have to double-check.
Reply
10-02-2020, 11:51 PM,
#14
RE: Customer Special Price: expired but still grabbed
Hi Paul, what I meant was that this script explicitly uses zero dates.

Tim
Reply
10-02-2020, 11:53 PM,
#15
RE: Customer Special Price: expired but still grabbed
Oh, ok. (old query habits, maybe)
Reply
10-06-2020, 04:39 AM,
#16
RE: Customer Special Price: expired but still grabbed
falkoner Wrote:
HDeriauFF Wrote:Phil, any feedback on the solution I submitted?

I have been playing around with this, and have the attached version working (the changes may be the same as yours in which case I apologise).



This *seems* to work on all scenarios but would appreciate your testing.

A couple of general comments that arose when I looked into this:

1 I thought a decision had been taken a while back to get rid of zero dates as they there are some sql-mode settings in mysql that prohibit them.
2 We should really get rid of all the .inc files and replace them with .php. This was done with some files but not all.

Thanks
Tim


the GetPrice file you provided works for me with the following scenarios:

[ul]
[li]Product with two [same customer] special prices, both end dates in the past[/li]
[li]Product with two [same customer] special prices, one end date in the past, the other one at zero[/li]
[li]Product with two [different customers] special prices,both end dates in the past[/li]
[li]Product with two [different customers] special prices, one end date in the past, the other one at zero[/li]
[/ul]
Thanks!
 
Reply
10-06-2020, 07:41 AM,
#17
RE: Customer Special Price: expired but still grabbed
Thanks, I have committed these changes and submitted a pull request

Tim
Reply
10-08-2020, 01:43 PM,
#18
RE: Customer Special Price: expired but still grabbed
I saw that Phil pulled it, thanks Tim. (Phil beat me to it by about 15 mins)
Reply
10-08-2020, 10:18 PM,
#19
RE: Customer Special Price: expired but still grabbed
Thanks Paul
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)