Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
bug: Internal stock request
04-08-2020, 10:04 PM,
#1
bug: Internal stock request
file InternalStockRequest.php, line 209 and line 237:

variable $myrow while in the while-loop this variable name is $MyRow.

cannot upload png-file to show this bug.

PHP Code:
while ($myrow=DB_fetch_array($result)){
    if (isset(
$_SESSION['Request']->Location) AND $_SESSION['Request']->Location==$myrow['loccode']){
        echo 
'<option selected value="'$MyRow['loccode'], '">'$MyRow['loccode'], ' - 'htmlspecialchars($MyRow['locationname'], ENT_QUOTES,'UTF-8'), '</option>';
    } else {
        echo 
'<option value="'$MyRow['loccode'], '">'$MyRow['loccode'], ' - 'htmlspecialchars($MyRow['locationname'], ENT_QUOTES,'UTF-8'),  '</option>';
    }


should be revised to:
PHP Code:
while ($MyRow=DB_fetch_array($result)){
    if (isset(
$_SESSION['Request']->Location) AND $_SESSION['Request']->Location==$myrow['loccode']){
        echo 
'<option selected value="'$MyRow['loccode'], '">'$MyRow['loccode'], ' - 'htmlspecialchars($MyRow['locationname'], ENT_QUOTES,'UTF-8'), '</option>';
    } else {
        echo 
'<option value="'$MyRow['loccode'], '">'$MyRow['loccode'], ' - 'htmlspecialchars($MyRow['locationname'], ENT_QUOTES,'UTF-8'),  '</option>';
    }



Attached Files Thumbnail(s)
   
Reply
04-09-2020, 12:28 AM,
#2
RE: bug: Internal stock request
Thanks for the report on that, ge_zhiyuan!

Will get that change applied later today.
Reply
04-09-2020, 12:23 PM, (This post was last modified: 04-09-2020, 12:36 PM by TurboPT.)
#3
RE: bug: Internal stock request
Hello, ge_zhiyuan!

Checking this file tonight, it looks like that was fixed back in September, along with some other variable name issues.
Thanks for the report, was worth checking!

GitHub file reference

GitHub commit diff reference
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)