Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
StockMovements.php: wrong results when customer has several branches
02-09-2019, 05:15 AM
Post: #1
StockMovements.php: wrong results when customer has several branches
a stock movement report for an item sold to one branch of a customer with multiple branches shows repeating rows for all branches

Line 73: changed from:
Code:
$sql = "SELECT stockmoves.stockid,
                systypes.typename,
                stockmoves.type,
                stockmoves.transno,
                stockmoves.trandate,
                stockmoves.userid,
                stockmoves.debtorno,
                stockmoves.branchcode,
                custbranch.brname,
                stockmoves.qty,
                stockmoves.reference,
                stockmoves.price,
                stockmoves.discountpercent,
                stockmoves.newqoh,
                stockmaster.decimalplaces
        FROM stockmoves
        INNER JOIN systypes ON stockmoves.type=systypes.typeid
        INNER JOIN stockmaster ON stockmoves.stockid=stockmaster.stockid
        INNER JOIN custbranch ON stockmoves.debtorno=custbranch.debtorno
        WHERE  stockmoves.loccode='" . $_POST['StockLocation'] . "'
        AND stockmoves.trandate >= '". $SQLAfterDate . "'
        AND stockmoves.stockid = '" . $StockID . "'
        AND stockmoves.trandate <= '" . $SQLBeforeDate . "'
        AND hidemovt=0
        ORDER BY stkmoveno DESC";

to:

Code:
$sql = "SELECT stockmoves.stockid,
                systypes.typename,
                stockmoves.type,
                stockmoves.transno,
                stockmoves.trandate,
                stockmoves.userid,
                stockmoves.debtorno,
                stockmoves.branchcode,
                custbranch.brname,
                stockmoves.qty,
                stockmoves.reference,
                stockmoves.price,
                stockmoves.discountpercent,
                stockmoves.newqoh,
                stockmaster.decimalplaces
        FROM stockmoves
        INNER JOIN systypes ON stockmoves.type=systypes.typeid
        INNER JOIN stockmaster ON stockmoves.stockid=stockmaster.stockid
        INNER JOIN custbranch ON stockmoves.debtorno=custbranch.debtorno
        WHERE  stockmoves.loccode='" . $_POST['StockLocation'] . "'
        AND stockmoves.trandate >= '". $SQLAfterDate . "'
        AND stockmoves.stockid = '" . $StockID . "'
        AND stockmoves.trandate <= '" . $SQLBeforeDate . "'
        AND stockmoves.branchcode = custbranch.branchcode
        AND hidemovt=0
        ORDER BY stkmoveno DESC";

attached before and after


Attached File(s) Thumbnail(s)
       
Find all posts by this user
Quote this message in a reply
02-09-2019, 08:55 PM
Post: #2
RE: StockMovements.php: wrong results when customer has several branches
Nice catch -- Thank you.

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
02-13-2019, 12:37 PM (This post was last modified: 02-13-2019 12:42 PM by TurboPT.)
Post: #3
RE: StockMovements.php: wrong results when customer has several branches
@HDeriauFF

...is the custbranch JOIN your addition to get the custbranch.brname ?

I don't see that custbranch is in the repository as a part of that query.
Not saying that it is wrong, but appears to be a custom change?

This is the current query in the repository for StockMovements:
Code:
$SQL = "SELECT stockmoves.stockid,
                systypes.typename,
                stockmoves.stkmoveno,
                stockmoves.type,
                stockmoves.transno,
                stockmoves.trandate,
                stockmoves.userid,
                stockmoves.debtorno,
                stockmoves.branchcode,
                stockmoves.qty,
                stockmoves.reference,
                stockmoves.price,
                stockmoves.discountpercent,
                stockmoves.newqoh,
                stockmoves.narrative,
                stockmaster.decimalplaces,
                stockmaster.controlled,
                stockmaster.serialised
        FROM stockmoves
        INNER JOIN systypes
            ON stockmoves.type=systypes.typeid
        INNER JOIN stockmaster
            ON stockmoves.stockid=stockmaster.stockid
        WHERE  stockmoves.loccode='" . $_POST['StockLocation'] . "'
            AND stockmoves.trandate >= '" . $SQLAfterDate . "'
            AND stockmoves.stockid = '" . $StockID . "'
            AND stockmoves.trandate <= '" . $SQLBeforeDate . "'
            AND hidemovt=0
        ORDER BY stkmoveno DESC";

...if it happens to have been added as part of another post, then please add a link. I'm trying to catch-up on other forum changes/submissions since December.
Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)