Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Tab key in SelectOrderItems.php
04-04-2018, 04:06 AM
Post: #1
Tab key in SelectOrderItems.php
The tab key does not behave consistently when entering item quantities. The first few rows require multiple tabs to move to the next field. The subsequent rows only require a single tab.
The html shows duplicate tabindex values for 8,9,10 and 11 . It looks like the field name="OrderQty0" should start at a tabindex of 11 or 12 instead of 8.
I have not yet found the lines in the php that would need to change.

Jeff
Find all posts by this user
Quote this message in a reply
04-04-2018, 04:14 AM
Post: #2
RE: Tab key in SelectOrderItems.php
I think the tab index attributes should all be taken out and then it will just naturally run from top to bottom.

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
04-04-2018, 05:33 AM
Post: #3
RE: Tab key in SelectOrderItems.php
Thanks Tim!

I removed all of the tabindex attributes on my install. This fixed the tabbing issue with no adverse effects as far as I can tell.
Find all posts by this user
Quote this message in a reply
04-04-2018, 08:16 AM
Post: #4
RE: Tab key in SelectOrderItems.php
I think it might have been me that put them there many years ago!

But they can definitely come out
Visit this user's website Find all posts by this user
Quote this message in a reply
04-05-2018, 06:22 AM
Post: #5
RE: Tab key in SelectOrderItems.php
Looks like I spoke too soon ...
Removing tabindex="%s" at line 1750 allows the tab key to behave correctly,
but the "Add to Sales Order" button no longer takes me to the Enter Delivery Details screen (see attached) instead it goes back to the item search form.
Leaving it in but removing the other tabindex attributes appears to give the desired result. More testing to follow...


Attached File(s) Thumbnail(s)
   
Find all posts by this user
Quote this message in a reply
04-05-2018, 04:26 PM
Post: #6
RE: Tab key in SelectOrderItems.php
Hi Jeff you need to take out the $i, at line 1770 which is being substituted for the %s

Thanks
Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
04-05-2018, 11:23 PM
Post: #7
RE: Tab key in SelectOrderItems.php
Tim,
Did you mean line 1764? I'm looking at SelectOrderItems.php revised on 2017-04-13. Did I miss something?

Thanks,
Jeff
Find all posts by this user
Quote this message in a reply
04-05-2018, 11:40 PM
Post: #8
RE: Tab key in SelectOrderItems.php
Possibly. I was looking at the latest file from github. In the printf function you should see two lines with $i, in them. Remove one along with the tabindex.

Basically in a printf you enter a %s and at the end list the variables that are substituted for the %s. You were removing the %s but not the variable. Sorry I am typing this on my phone so it may not make sense?
Visit this user's website Find all posts by this user
Quote this message in a reply
04-06-2018, 04:17 AM
Post: #9
RE: Tab key in SelectOrderItems.php
OK, that is what I did. Everything appears to be working correctly now.
There is a nearly identical section of code about 175 lines up. Should this have $i, removed as well?

Thanks,
Jeff
Find all posts by this user
Quote this message in a reply
04-06-2018, 05:17 AM
Post: #10
RE: Tab key in SelectOrderItems.php
Hi Jeff I will check later when I have access to the code. The basic idea is that the number of parameters at the end of a printf function should be the same as the number of occurrences of %s in the first part

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)