Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
double posting in both General ledger Accounting
03-10-2018, 04:33 AM (This post was last modified: 03-10-2018 04:46 AM by TurboPT.)
Post: #21
RE: double posting in both General ledger Accounting
Oh yeah, I recall past discussions on that one... eventually, as I believe that you've mentioned at some point in the past, the last ?> in the file should probably be eliminated to avoid the potential hassles that can be caused by that situation.

https://kinsta.com/blog/10-things-not-to-do-in-php-7/ Wrote:3. Do Not Use PHP Close Tags At The End Of A file

If you take a look, most core WordPress files omit the ending PHP tag when a file ends with PHP code. In fact, the Zend Framework specifically forbids it. It is not required by PHP and by omitting it at the end of a file you are making sure that no trailing whitespace can be added.

=====

Back to the other whitespaces for a moment, about the only argument that I've ever heard against that is, "...it makes a diff more difficult to review because it appears to have more changes than the actual change(s) applied." ... the trouble with that is, many diffs can ignore the whitespace change differences so that only the actual change(s) are indicated.
Find all posts by this user
Quote this message in a reply
03-10-2018, 08:29 AM
Post: #22
RE: double posting in both General ledger Accounting
You are correct Paul that it makes that commit harder to review, but I always feel that shouldn't prevent us doing what is right.

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
03-10-2018, 10:42 AM (This post was last modified: 03-10-2018 10:45 AM by TurboPT.)
Post: #23
RE: double posting in both General ledger Accounting
That's right Tim, no trouble for me. The "only argument" was from others ... I've never had trouble with such changes myself.
Find all posts by this user
Quote this message in a reply
03-12-2018, 06:20 PM
Post: #24
RE: double posting in both General ledger Accounting
(03-09-2018 06:12 PM)falkoner Wrote:  Ok, I have fixed the page refresh issue and pushed the fix to github.

https://github.com/timschofield/webERP-s...68f58cf279

Tim
I noticed that my code editor had automatically removed some trailing white space from the end of lines. This isn't to sabotage the project as has previously been said, but is actually a good thing. Most code editors can be set to do this, and it would be good if developers set this.

Tim



Hello Tim,
thanks for your reply but as i can't find this file 'PcAuthorizeCash.php'.
Am using webERP version 4.14.1
Find all posts by this user
Quote this message in a reply
03-12-2018, 10:31 PM (This post was last modified: 03-12-2018 10:34 PM by VortecCPI.)
Post: #25
RE: double posting in both General ledger Accounting
(03-12-2018 06:20 PM)wissedenis22 Wrote:  Hello Tim,
thanks for your reply but as i can't find this file 'PcAuthorizeCash.php'.
Am using webERP version 4.14.1

PcAuthorizeCash.php is a new script (i.e., not part of 4.14.1) and requires an entry in MainMenuLinks.php to be utilized.

   

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
03-12-2018, 10:49 PM
Post: #26
RE: double posting in both General ledger Accounting
Yes, the authorisation of expenses and assigned cash been will be split into two scripts, in the next release, to allow a different authoriser for each.

I will try to apply Tims fix to the 4.14.1 release of PcAuthorizeExpenses.php later today, and will share here.

Andy.

https://www.linkedin.com/in/andrewcouling
Find all posts by this user
Quote this message in a reply
03-15-2018, 03:54 AM
Post: #27
RE: double posting in both General ledger Accounting
(03-12-2018 10:49 PM)afcouling Wrote:  Yes, the authorisation of expenses and assigned cash been will be split into two scripts, in the next release, to allow a different authoriser for each.

I will try to apply Tims fix to the 4.14.1 release of PcAuthorizeExpenses.php later today, and will share here.

Andy.

@wissedenis22

I have applied Tims fix to the 4.14.1 release of PcAuthorizeExpenses.php.
I have not tested this.
Please backup the existing file, and test thoroughly, before using on a production instance.

Andy.


.php  PcAuthorizeExpenses.php (Size: 10.26 KB / Downloads: 1)

https://www.linkedin.com/in/andrewcouling
Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)