01-30-2018, 02:52 AM,
(This post was last modified: 01-30-2018, 02:53 AM by VortecCPI.)
|
|
VortecCPI
Paul Becker
|
Posts: 751
Threads: 211
Joined: Apr 2017
|
|
RE: Lot numbers not printed in landscape
Again this is just my OCD kicking in and wanting code to be as consistent as possible. My "mild OCD" can be a curse...
Funny... Way back in the old days I was not all too concerned about coding standards and/or consistency. Then I read MS "Practical Standards for Visual Basic" and my OCD kicked in full. Now all the code I construct is super-tidy and structured and I welcome an audit.
Thank you for all your help Paul!
https://www.linkedin.com/in/eclipsepaulbecker
|
|
01-30-2018, 03:33 AM,
|
|
VortecCPI
Paul Becker
|
Posts: 751
Threads: 211
Joined: Apr 2017
|
|
RE: Lot numbers not printed in landscape
I have been looking at Portrait and it is significantly different. We prefer landscape due to potentially-long narratives but I will continue to look at it.
Right now we are in GO mode so I am a bit wary of changing anything in production but that does not prevent me from testing.
The security code seems to make sense for a salesman login but our salesmen do not have access to webERP because they do all their work in SuiteCRM. I will have to create a test account to check that piece out better.
https://www.linkedin.com/in/eclipsepaulbecker
|
|
01-30-2018, 04:02 AM,
(This post was last modified: 01-30-2018, 04:05 AM by VortecCPI.)
|
|
VortecCPI
Paul Becker
|
Posts: 751
Threads: 211
Joined: Apr 2017
|
|
RE: Lot numbers not printed in landscape
So the new securitycode added salesman.salesmancode to the queries but it is using $myrow['salesman']?
I believe it should be using $myrow['salesmancode'] or we should add/use salesorders.salesperson.
The purpose is to disallow a salesman from seeing sales trans data related to other salesman
https://www.linkedin.com/in/eclipsepaulbecker
|
|
01-30-2018, 04:36 AM,
(This post was last modified: 01-30-2018, 05:13 AM by VortecCPI.)
|
|
VortecCPI
Paul Becker
|
Posts: 751
Threads: 211
Joined: Apr 2017
|
|
RE: Lot numbers not printed in landscape
Perhaps these are site-/customer-/implementation-specific changes finding their way in here.
i believe the idea is a customer may belong to a certain Salesman but the Sales Order could belong to another.
I think the idea is a good one but it seems it was never fully checked and completed.
The security code is similar to that found in SelectOrderitems.php:
17/10/23 Exson: Prevent customer from modifying or viewing other customer's order in SelectOrderItems.php and PrintCustTrans.php.
So looks like he may have forgotten to change $myrow['salesman'] to $myrow['salesperson']?
https://www.linkedin.com/in/eclipsepaulbecker
|
|
01-30-2018, 06:03 AM,
|
|
VortecCPI
Paul Becker
|
Posts: 751
Threads: 211
Joined: Apr 2017
|
|
RE: Lot numbers not printed in landscape
My OCD is so happy right now...
https://www.linkedin.com/in/eclipsepaulbecker
|
|
|