Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Stray/Extra Line Terminators?
01-28-2018, 07:40 AM (This post was last modified: 01-28-2018 07:41 AM by VortecCPI.)
Post: #1
Stray/Extra Line Terminators?
While working on MRPPlannedPurchaseOrders.php and MRPPlannedWorkOrders.php I noticed a few cases where we have terminators (";") after closing brackets ("}") for if-then statements.

I did a search and there are other places where we have the same.

Should we tidy this up to be consistent?

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-28-2018, 08:24 AM (This post was last modified: 01-28-2018 08:36 AM by TurboPT.)
Post: #2
RE: Stray/Extra Line Terminators?
Yes, I'll look for those right now.

There are some places where the ; may remain after the }

I show occurrences in about 11 files, not including the 3rd-party areas that I won't touch at the moment.
Find all posts by this user
Quote this message in a reply
01-28-2018, 09:02 AM
Post: #3
RE: Stray/Extra Line Terminators?
Changes committed to SVN.
Find all posts by this user
Quote this message in a reply
01-28-2018, 09:50 AM (This post was last modified: 01-28-2018 09:51 AM by VortecCPI.)
Post: #4
RE: Stray/Extra Line Terminators?
Wow! That was quick! Thank you so much!

Now for another nit-picky thing I just found...

Most scripts (304) use <a href=" (double-quote) but a few (5) use <a href=' (single quote). I just noticed it now when comparing the two MRP planning scrips.

Not too sure what our coding standard says about this but it seems it should be the same...

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-28-2018, 11:31 AM (This post was last modified: 01-28-2018 11:38 AM by TurboPT.)
Post: #5
RE: Stray/Extra Line Terminators?
I believe that some of the single quote ones could be missing a double quote?

For example, in file MRPPlannedPurchaseOrders.php, line 17, this link:
PHP Code:
'<a href='.$RootPath .'/MRP.php>' 

...should look like this with the double quotes applied to complete the href as expected:
PHP Code:
'<a href="'.$RootPath .'/MRP.php">' 

So, in all, it may depend on what quote the string starts with as well as how the concatenation is applied, if any.

But yes, as you have found, there are inconsistencies.
Find all posts by this user
Quote this message in a reply
01-28-2018, 11:38 AM
Post: #6
RE: Stray/Extra Line Terminators?
Thank you Paul. Bothers me and my OCD...

I have another feature you may want to have a look at here: http://www.weberp.org/forum/showthread.php?tid=8061

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-28-2018, 12:03 PM
Post: #7
RE: Stray/Extra Line Terminators?
Yes, I saw that feature, I was first considering another that you posted first now that the pick list is committed:

http://www.weberp.org/forum/showthread.php?tid=8048
Find all posts by this user
Quote this message in a reply
01-28-2018, 10:55 PM
Post: #8
RE: Stray/Extra Line Terminators?
(01-28-2018 12:03 PM)TurboPT Wrote:  Yes, I saw that feature, I was first considering another that you posted first now that the pick list is committed:

http://www.weberp.org/forum/showthread.php?tid=8048

Thank you Paul. It is very helpful to me and I figured others could also benefit.

PLEASE check my work as PHP is NOT my native coding environment!

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)