Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Language - _('Unit') Versus _('Units')
01-16-2018, 11:55 PM (This post was last modified: 01-16-2018 11:59 PM by VortecCPI.)
Post: #1
Language - _('Unit') Versus _('Units')
We use _('Unit') in 20 scripts and _('Units') in 55 scripts.

Is this by design or has this somehow slipped in by legacy or mistake?

Can we (should we) unify these so one change to language manages the entire system?

   

   

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-18-2018, 02:03 AM (This post was last modified: 01-18-2018 02:08 AM by VortecCPI.)
Post: #2
RE: Language - _('Unit') Versus _('Units')
Also... In messages.po in (3) places we have "Units of Measure" while all the other strings have "Unit of Measure".

I know, I know... I am being nit-picky here...

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-19-2018, 09:03 PM (This post was last modified: 01-19-2018 09:04 PM by afcouling.)
Post: #3
RE: Language - _('Unit') Versus _('Units')
Hi Paul,

It would be great to have some consistency here.
The singular form sounds better to me.
How would you go about 'unifying' this?

If you are willing, I recommend that you make the necessary changes, and submit the code to submissions@weberp.org, as per the instructions in the Wiki.

Please continue to be 'nit-picky'.

Andy.

https://www.linkedin.com/in/andrewcouling
Find all posts by this user
Quote this message in a reply
01-19-2018, 10:30 PM (This post was last modified: 01-19-2018 10:41 PM by VortecCPI.)
Post: #4
RE: Language - _('Unit') Versus _('Units')
I have looked at ANSI and ASTM and there is no consistency. Sort of like "Bill of Material" and "Bill of Materials". Silly English language!

Since there are only 20 scripts using _('Unit') it seems to make more sense to change those to _('Units') and go from there.

I assume we just merge these together in messages.po?

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-19-2018, 10:41 PM
Post: #5
RE: Language - _('Unit') Versus _('Units')
I have no experience with Gettext translations, so can't confirm, but I'm aware that
Poedit is a popular tool for maintaining language files.

Andy.

https://www.linkedin.com/in/andrewcouling
Find all posts by this user
Quote this message in a reply
01-19-2018, 11:05 PM
Post: #6
RE: Language - _('Unit') Versus _('Units')
Same issue for "Bill of Material" and "Bill of Materials".

"Bill of Material" occurs in 10 scripts and "Bill of Materials" occurs in 16 scripts.

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-19-2018, 11:30 PM
Post: #7
RE: Language - _('Unit') Versus _('Units')
Bill of materials is the correct usage as there will (normally) be more than one component.

These are serious issues because by eliminating multiple versions of the same string we make life much easier for translators.

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
01-19-2018, 11:30 PM (This post was last modified: 01-19-2018 11:34 PM by VortecCPI.)
Post: #8
RE: Language - _('Unit') Versus _('Units')
I am no English Grammar expert but here is my take on it...

"Unit of Measure" is that which describes a line item's measure (e.g., "EA").
"Units of Measure" is a list comprised of various "Unit of Measure" (e.g., "DZ, EA, FT, GA, LB")

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-19-2018, 11:40 PM
Post: #9
RE: Language - _('Unit') Versus _('Units')
Using UnitsOfMeasure.php as an example, in my opinion, the page title "Units of Measure" is correct, but the table column header should be "Unit of Measure".

It seems that if this is to be reviewed, it should be done script by script, rather than in one fell swoop.

#canofworms

Andy.

https://www.linkedin.com/in/andrewcouling
Find all posts by this user
Quote this message in a reply
01-19-2018, 11:51 PM
Post: #10
RE: Language - _('Unit') Versus _('Units')
Agreed and while it adds little (or no) true value to webERP it does make it consistent.

Since we have a new release coming soon perhaps we should try to get some of this done?

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)