Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Tax Rates Do Not Add Up - SOLVED?
12-27-2017, 10:56 PM (This post was last modified: 12-28-2017 05:37 AM by VortecCPI.)
Post: #1
Tax Rates Do Not Add Up - SOLVED?
When using a one-to-many relationship for tax rates the total tax rate is not concatenating.

Looking at PDFQuotation.php It appears as if the SQL only uses one associated record and it should use associated records.

I built a Tax Group of 7% by concatenating Tax Authorities and applicable rates but i only end up with 4% as the Tax Rate.

The idea is to be able to build Tax Rates similar to building a binary number in that it is simply combinations of Tax Rates.

   

   

   

The logic shown above results in a Tax rate of 4% instead of 7% and I believe that is due to the 4th SQL loop being outside of the 3rd SQL loop.

My fixes are attached so can somebody please verify my work, especially with respect to tax upon tax flag.


Attached File(s)
.php  PDFQuotation.php (Size: 11.48 KB / Downloads: 1)
.php  PDFQuotationPortrait.php (Size: 11 KB / Downloads: 1)

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
12-28-2017, 02:46 PM
Post: #2
RE: Tax Rates Do Not Add Up - SOLVED?
I cannot verify, for I don't have any of that data in my system, but if someone else can at least try/verify the files, I do NOT mind committing the files to SVN.
Find all posts by this user
Quote this message in a reply
12-28-2017, 10:24 PM
Post: #3
RE: Tax Rates Do Not Add Up - SOLVED?
Is this only true for quotations or does the error transfer through to the order as well? In many locales (the UK for instance) it is not normal to include the tax on a quotation, and it wasn't initially included in the quotation report. If I recall correctly Rafael added this in a while back and it maybe he made the mistake then.

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
12-28-2017, 11:09 PM
Post: #4
RE: Tax Rates Do Not Add Up - SOLVED?
The tax rate was already on the quotation so I can only assume it should be included.

However... I do understand that it is not necessary for bid purposes.

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
12-29-2017, 12:41 AM
Post: #5
RE: Tax Rates Do Not Add Up - SOLVED?
Hi Paul yes it is included but it wasn't till a few years ago when Rafael wrote the tax code into the quotation. My point was that it wasn't included as part of the initial tax code and so doesn't seem to follow the same rules. It obviously needs correcting though I would like to see it being optional on the quotation anyway.

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
12-29-2017, 12:48 AM (This post was last modified: 12-29-2017 12:51 AM by VortecCPI.)
Post: #6
RE: Tax Rates Do Not Add Up - SOLVED?
I agree that it could be optional. I have been involved in estimate/proposal/quotation generation for many decades and we never included sales tax data.

To be honest, it is often painful to determine sales tax so it is a non-value-added task at time of estimate/proposal/quotation. It is something best left to accounting at time of billing.

If a PO from a customer must include total amount (i.e., plus tax) then it becomes useful but, again, that can be done at time of Sales Confirmation.

In any case, and to your point, rules, consistency, and predictability are always helpful.

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-10-2018, 10:15 AM (This post was last modified: 01-10-2018 02:35 PM by TurboPT.)
Post: #7
RE: Tax Rates Do Not Add Up - SOLVED?
Tim,

...so are these changes for commit, or a "hold for now" matter?
Find all posts by this user
Quote this message in a reply
01-10-2018, 08:03 PM
Post: #8
RE: Tax Rates Do Not Add Up - SOLVED?
Whether or not you want tax to be shown on a quotation seems to be very much dependent on your location. For my EU customers it makes no sense, whereas in Africa they want it. So for me the only way is to make it an option in the configuration, but I haven't had time to look at the code, so am not sure how much is involved in doing that.

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
01-11-2018, 02:15 PM (This post was last modified: 01-11-2018 02:35 PM by TurboPT.)
Post: #9
RE: Tax Rates Do Not Add Up - SOLVED?
Ok Tim, based on the "should be configurable", then I'll classify this as "hold for now" to minimize impact.

I need to get back to the pick list matter, as I got off on a tangent ensuring that I was committing Paul's, yours (as well as other user's) proposed changes (or fixes to reported bugs) back through November. (I started committing around Dec. 11th)

Phil has mentioned that there may be a release soon, and Exson is investigating a BOM-related bug. (not sure of the specifics)

I *believe* that I have caught-up with all the *known* matters at this time (at least from Nov. to now, some others before then appear to have been covered by others)

After the pick list, I can look back at this issue to see what might be necessary to include this "feature" in the configuration too.
Find all posts by this user
Quote this message in a reply
01-11-2018, 05:27 PM
Post: #10
RE: Tax Rates Do Not Add Up - SOLVED?
As well as Exson's BOM bu I have reported two other bugs that have been committed to the developers who committed them and these need to be fixed before any release is done.

Tim
Visit this user's website Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)