Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Picking List: only the first item of an order is printed
01-27-2018, 02:45 AM,
#61
RE: Picking List: only the first item of an order is printed
Usually Major.Minor.Fix/Patch

Since we have added some features we just need to decide if they are "Major" or "Minor".

An interesting take here: https://semver.org
https://www.linkedin.com/in/eclipsepaulbecker
Reply
01-27-2018, 03:01 AM,
#62
RE: Picking List: only the first item of an order is printed
What I was meaning was that the numbers used in the update sql file sometimes change when the release is done. I don't think the revision number is known until the release is done but obviously that file has to be created earlier.

To be honest the sql upgrade system is broken and was chosen because of personal vendettas rather than technical merit.
Reply
01-27-2018, 08:01 AM, (This post was last modified: 01-27-2018, 11:50 AM by TurboPT.)
#63
RE: Picking List: only the first item of an order is printed
(01-26-2018, 11:13 AM)HDeriauFF Wrote:
(01-22-2018, 06:03 PM)falkoner Wrote: Thanks Paul, I have fixed those.

Maybe the original poster for this thread is a good tester as they have a particular use case?

Tim

Hi yes I would be happy to go through testing.
Let me know where to grab the files and I will provide some feedback.

Thank you!
HDeriauFF,

How would you like to receive the files?

There are 25 total files, 9 are new, 16 are modified, but 3 of the modified files will not have direct need as they are changes to the version update and new DB installation files.

I also have a separate SQL file that only contains specific pick list updates, because the "version update" file contains more than just the new pick list-related changes for the next version.

So based on that, I can perceive handling this one of three ways: (unless you have another idea?)
  1. Provide a SVN link to the commit, with a list of the 3 files to ignore, along with the separate 'special' SQL update file that I can post here? Know that from the SVN link, you will need to individually download 22 files.
  2. I can post two files here: a zip of the 22 files that you need, which can be extracted at the webERP directory, along with the separate 'special' SQL update file?
  3. If you already have a repository reference that you update yourself, then I can post the 'special' SQL update file here, and the 3 files to ignore.
The special SQL update will also attempt to migrate any existing pickinglist table info. However, if you don't care about what is already in those old tables (since it was not working), you can delete the info to skip the migration, if desired. These pick list changes are NEW! New tables and scripts along with certain modifications within other scripts to support the new handling.

Basically, the new changes will obsolete the PDFPickingList.php file and the two tables that it references.
Reply
01-27-2018, 04:59 PM, (This post was last modified: 01-27-2018, 04:59 PM by TurboPT.)
#64
RE: Picking List: only the first item of an order is printed
(01-26-2018, 11:13 AM)HDeriauFF Wrote:
(01-22-2018, 06:03 PM)falkoner Wrote: Thanks Paul, I have fixed those.

Maybe the original poster for this thread is a good tester as they have a particular use case?

Tim

Hi yes I would be happy to go through testing.
Let me know where to grab the files and I will provide some feedback.

Thank you!
HDeriauFF,

How would you like to receive the files?

I could provide a link to SVN (after I commit), but you will not need all the files that are committed. There are 25 total files, 9 are new, 16 are modified, but 3 of the modified files will not have direct need as they are changes to the version update and new DB installation files.

I also have a separate SQL file that only contains specific pick list updates, because the "version update" file contains more than just the new pick list-related changes.

So based on that, I can perceive handling this one of three ways: (unless you have another idea?)
  1. Provide a SVN link to the commit, with a list of the 3 files to ignore, along with the 'special' SQL update file that I can post here? Know that from the SVN link, you will need to individually download 22 files.
  2. I can post two files here: a zip of the 22 files that you need, which can be extracted at the webERP directory, along with the special SQL update file?
  3. If you already have a repository reference that you update yourself, then I can give you the special SQL update, and the 3 files to ignore.
The special SQL update will also attempt to migrate any existing pickinglist table info. However, if you don't care about what is already in those old tables (since it was not working), you can delete the info to skip the migration, if desired. These pick list changes are NEW! New tables and scripts along with certain modifications within other scripts to support the new handling.

Basically, the new changes will obsolete the PDFPickingList.php file and the two tables that it references.
Reply
01-27-2018, 06:46 PM,
#65
RE: Picking List: only the first item of an order is printed
I see you have committed this. Great work Paul!
Reply
01-28-2018, 01:50 AM,
#66
RE: Picking List: only the first item of an order is printed
Wow. Lots of work done here and some good fixes such as those found in Z_ChangeStockCode.php.

Great work -- LOTS of changes to webERP since 4.14.1!
https://www.linkedin.com/in/eclipsepaulbecker
Reply
01-28-2018, 03:39 AM, (This post was last modified: 01-28-2018, 04:11 AM by TurboPT.)
#67
RE: Picking List: only the first item of an order is printed
Thanks, yes, I was wanting to get this feature committed by the weekend.

Though there was originally only two pick-related changes to the Z_ChangeStockCode, I noted a few missing fields for the insert/select, so I added the fields and moved a few fields to match the order as they appear in the table. (to ease cross-checking) I will have another small cleanup matter to this file, likely this weekend, but I kept the vast amount of changes as minimal as possible, keeping close to the feature.
Reply
01-28-2018, 04:14 AM,
#68
RE: Picking List: only the first item of an order is printed
I am looking forward to reconciling all my changes with a new version since so many of my changes have been covered by you and others.

It is very exciting to see all this work happing on an open-source project...
https://www.linkedin.com/in/eclipsepaulbecker
Reply
01-28-2018, 08:25 AM,
#69
RE: Picking List: only the first item of an order is printed
Paul, if you are looking for another feature to bring in from my repository I can recommend the functionality to add multiple tags to a transaction. At the moment you can only have the one. This makes the tagging feature a very flexible tool allowing the general ledger to be reported in a possible infinite number of ways. It is one of those things you have to think about but once you do you start seeing so many useful things you can do with it.

It is also something that others don't have.

Tim
Reply
01-28-2018, 09:25 AM,
#70
RE: Picking List: only the first item of an order is printed
Yes, I'll consider that, but first I'd like to try and cover the few (if not a bit more) outstanding items within the forums.
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)