Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Delete Sales Transactions - Unused Choices?
11-26-2017, 11:14 PM, (This post was last modified: 11-27-2017, 03:17 AM by VortecCPI.)
Delete Sales Transactions - Unused Choices?
Main Menu > Delete All Sales Transactions (Z_DeleteSalesTransActions.php)

It appears we have some unused choices and code:



From what I can see in the code these two checkboxes and their related POST values are not used anywhere else in the code.

Is this an actual issue, my mistake, or part of a work-in-progress?
11-27-2017, 08:33 AM,
RE: Delete Sales Transactions - Unused Choices?
This got removed about 12 years ago not sure why, the commit message is not particularly helpful.

I would be careful when using any of the delete Z_*.php scripts especially on a production server.

Firstly because many of them are old, and haven't been properly maintained - there isn't really any change to the logic of the scripts in over a decade whereas the code itself has moved on considerably so inconsistencies can happen.

Secondly, as an accountant I have an inbuilt dislike of removing a transactions that form part of the history of the ledgers.


Forum Jump:

Users browsing this thread: 2 Guest(s)