Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Possible Bug/Issue SQL Vesus EDI Path
11-17-2017, 11:43 PM (This post was last modified: 11-17-2017 11:56 PM by VortecCPI.)
Post: #1
Possible Bug/Issue SQL Vesus EDI Path
I just noticed in a SQL dump the path to EDI Sent Messages is .../EDI__Sent but the path at the server is .../EDI_Sent (note quantity of "_")

I created a new test company to verify and the path on the server has one "_" but the path in the database has two "__".

Having a look at the "default.sql" file I see two "__" at line 6649:

INSERT INTO `config` VALUES ('EDI_MsgSent','companies/test/EDI__Sent');

In the "Z_MakeNewCompany.php" file we have:

$Result = mkdir('./companies/' . $_POST['NewDatabase'] . '/EDI__Sent'); at line 133

And also:

$SQL ="UPDATE config SET confvalue='companies/" . $_POST['NewDatabase'] . "/EDI__Sent' WHERE confname='EDI_MsgSent'"; at line 194

Is it correct to assume we only need one "_" in these files?
We also have another occurance of "EDI__Sent" on line 8570 in "demo.sql":

INSERT INTO `config` VALUES ('EDI_MsgSent','companies/test/EDI_Sent');


I am NOT trying to be a pest... Just trying to be sure I understand...

https://www.linkedin.com/in/eclipsepaulbecker
Visit this user's website Find all posts by this user
Quote this message in a reply
01-09-2018, 01:25 PM (This post was last modified: 01-10-2018 02:10 AM by TurboPT.)
Post: #2
RE: Possible Bug/Issue SQL Vesus EDI Path
Yes, I believe that the double underscore is an oversight.

Curiously though, line 133 in my (unmodified) Z_MakeNewCompany.php file only has 1 underscore.

I'll go ahead and make changes to remove the extra _ in all areas where a double underscore is found in the EDI__Sent, as it only appears in 3 places in the code base:
1. in the default.sql file [line 6664]
2. in the demo.sql file [line 8584]
3. in the Z_MakeNewCompany.php file [line 194]
Find all posts by this user
Quote this message in a reply
01-10-2018, 02:33 AM
Post: #3
RE: Possible Bug/Issue SQL Vesus EDI Path
Double underscores removed, committed to SVN.
Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)