v4.06.5 StockCategories bug

[Ahmed.Fawzy]

Sorry I could not find any change log to make sure of if this was fixed in newer version or not. Forgive me I never contribute to any open source communities before and I do not know what should be done to report this.

Tested on: FF 9.0.1

Bug 1

Problem: When checking the Numeric Value check box and entering numeric values in the default, minimum and maximum textboxes then submitting the form it always gives an error saying the minimum value is not numeric

Line: 573
Original Code: <td><input type="textbox" class="number" "name="PropMinimum' . $PropertyCounter . '" /></td>

Reason:The extra " before name

Solution: After deleting the extra " it works fine now.

Bug 2

Problem: After solving the first bug and although the message is telling me that my data was updated the numeric value check box is always empty after the submitting. I look in the DB and found the value = 1 (it is saved correctly). The problem was in the displaying of it.

Line: 483
Original code:
$sql = "SELECT stkcatpropid,
label,
controltype,
defaultvalue,
reqatsalesorder,
minimumvalue,
maximumvalue
FROM stockcatproperties
WHERE categoryid='" . $SelectedCategory . "'
ORDER BY stkcatpropid";

Reason: You are missing numericvalue selection in the query.

Solution: Add numericvalue to the selected columns in the query.
Line: 546

Original Code: echo '"></td>

Problem: This is another extra "

Solution: echo ' /></td>

[phil]

Awesome ... thankyou :-)
Fixes applied to svn today