Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Blank lines at end of scripts
02-26-2014, 05:51 PM,
#11
RE: Blank lines at end of scripts
The rule is matching tags and no newline at the end of files.
Phil Daintree
webERP Admin
Logic Works Ltd
http://www.logicworks.co.nz
Reply
02-26-2014, 07:03 PM,
#12
RE: Blank lines at end of scripts
(02-26-2014, 05:51 PM)phil Wrote: The rule is matching tags and no newline at the end of files.

Hi Phil, for some time now you have been adding new lines at the end of files. here you add a new line to the end of includes/PDFStockCheckPageHeader.inc

https://sourceforge.net/p/web-erp/code/6578/#diff-1

here to AddCustomerNotes.php and AddCustomerTypeNotes.php

https://sourceforge.net/p/web-erp/code/6575/#diff-1

and that is just your last couple of commits. It goes back months. We have spoken before about the need to apply the rules to everyone, and not just those you are trying to force off the project.

Tim
Reply
02-26-2014, 07:06 PM, (This post was last modified: 02-26-2014, 07:12 PM by phil.)
#13
RE: Blank lines at end of scripts
Thanks Tim - I will review and fix - might be sommat to do with settings to geany?

sure enough
   
Phil Daintree
webERP Admin
Logic Works Ltd
http://www.logicworks.co.nz
Reply
02-26-2014, 07:16 PM,
#14
RE: Blank lines at end of scripts
(02-26-2014, 07:06 PM)phil Wrote: Thanks Tim - I will review and fix - might be sommat to do with settings to geany?

sure enough

Thats what I suggested it would be on the 15th Feb

Tim
Reply


Forum Jump:


Users browsing this thread: 3 Guest(s)