Phil, it really shouldn't be this hard to get a simple common sense bug fixed. From the very beginning of webERP databases with upper case characters have been allowed. Do a manual install with any release up until the most recent and they all work with databases including upper case charaters. This is an indisputable fact. Not sure what the 2006date is about, webERP started before then.
Many installations were done this way, either just because people could, or because the hosting company demanded it. Most people used a manual installer. I don't think I committed the first installer until at least 2009, and even after that many still used the manual install.
This thread is not to do with the installer (I am not sure why you brought that up), it is to do with this change in in ConnectDB.inc that now makes any installation using one of these databases done over the last decade unusable. Shouldn't people have at least been told that had happened, even if it wasn't a subject for discussion.
I don't care about whether the installer allows upper case or not. To me it is unimportant. If you want that to force upper case letters now, then fine. It's unnecessary, but if it makes you happy, then I am happy. I do care that we should not just abandon long standing users on what seems a whim. This thread is about the bug mentioned by Vito in this thread. It is critical that this bug in ConnectDB.inc should be fixed so that the original poster in the thread and all those like him can continue to use webERP again, as they have been allowed to do over the last decade. We ought to be trying to bring users in, not get rid of those users who are already with us. Keeping this bug in makes no sense. It does nothing for people who may want to use postgresql as that doesn't allow upper case names in the database name, so they cannot have a database name containing containing upper case characters.
I really hope you can see past the fact that the person proposing this is currently subject to one of your vendettas and act in the interests of the webERP community.
Tim
(01-04-2014, 09:05 AM)phil Wrote: Of course, the strtolower function was added just to fix the installer to retain the convention we have used since ~ 2006.
Hi Phil, the strtolower() isn't in the installer. It is in the includes/ConnectDB.inc script - think about that for a second. If the code has reached ConnectDB.inc then the database must exist. Whatever characters it contains must be allowable by the DBMS in use, as it exists.
Now the strtolower() function is potentially going to change the variable name containing the database name to a different value. This means that webERP will not then work. This call to strtolower() function can do two things:
1 Either it does nothing and leaves the DB name as it is, or
2 It changes the DB name variable causes webERP to crash.
Both scenarios are not good. The first one means that we delay webERP with a pointless call, and the second we make a webERP that would work without it crash. (The second one is what caused Vito's crash). Removing this function call solved his issue.
I am confident that if you put aside your grudges and vendettas you will see that this is obvious.
Thanks
Tim