error in default.css

[vitaliy_s]

My browser flags an error in default.css file at this line
border: 0px 0px 2px 2px #222 solid;

Looks to me there are too many parameters here. It should have only 3: width, style and color. What do those extra parameters mean?

[phil]

Is this the same accross all themes?
Which theme is this? I'll try to figure out...

[phil]

Of course you are correct ... do you want to apply the fixes or should I (for all the themes) - I wonder if this .table1 and .table2 class is actually used - need to grep it... may be able to delete these lines if not used anywhere.

[vitaliy_s]

I found table1 in some files. Looks like table2 is not used anywhere.

[phil]

(01-19-2012 06:07 AM)vitaliy_s Wrote:  I found table1 in some files. Looks like table2 is not used anywhere.

So let's ditch .table2 from all default.css for all themes and fix the border: x y z calls I notice there are some others in gel and jelly themes

calls ... are you happy to do this? Don't forget the log entry in doc/Change.log

[vitaliy_s]

OK, i'll remove table2 and correct settings for table1

[phil]

Fantastic

[vitaliy_s]

Phil,
The update is on SVN.

I got this strange message after SVN Commit:

Your mail to 'Web-erp-svn' with the subject

SF.net SVN: web-erp:[4803] trunk

Is being held until the list moderator can review it for approval.

The reason it is being held:

Post by non-member to a members-only list

[phil]

My mistake sorry I always forget to add to the svn mailing list - it sends a diff of the changes made... all sorted now.

I notice in Prices.php - a funny thing? See link

http://web-erp.svn.sourceforge.net/viewv...34&r2=4803

It looks like I was not sending the Price value correctly but the " may be a problem in this code... will check later...

Code changes look pretty I see I missed a ; in the Tax changes to SupplierCredit.php and a typo in index.php - thanks for fixing!

Brilliant to have you helping with the code