DB_escape_string

[icedlava]

Hi Phil,

I have added a preliminary DB_query function to the new branch along with a few support functions.

I have tried to keep a consistent signature in line with your wish to use the one DB_query function. The signature of the function is now a little cumbersome when using bind vars as the full signature must be passed along with the $Bindvar array as the last in the signature (defaulting to null if none passed).

I have not yet fixed the audit trail section when $Bindvars are passed into the function.

I have also committed the AddCustomerContacts.php script updated to use the new $Bindvars array passed to DB_query.

As per already posted code, the result set is returned as an associative array, and for a single item this is already adjusted (current($result)).

This means that any scripts using the $result set can do a foreach ($result as $myrow) instead of the usual while loop.

Note - i have also adjusted session.inc and removed the DB_escape_string use on session, post and get vars. This should no longer be required and if not removed we'll end up with multiplying slashes in the database.

Feel free to make adjustments as deemed necessary on this draft code.

Cheers,

---

Hi serakfalcon,

I was thinking about the implementation of this and did some digging, Doctrine DBAL (http://jwage.com/post/31080076112/doctri...tion-layer ) looks very 'webERP'-y,

I looked at doctrine DBAL some time ago(and propel) when working on another open source project and looking for an ORM. While it is good, it was not used. It just added another layer of code and syntax to learn, and was rather slow although the latest Doctrine is much faster. Do we really need this for webERP?

For webERP, we do still need to look at how to effectively prep the post, get and session vars, as required for output to the browser, or ajax or PDF etc.

I'm thinking of an api to enable the convenient and consistent prepping on vars without, hopefully adding too much overhead.

Cheers,