DB_escape_string

[serakfalcon]

PHP 5.2 has been unsupported since 2011. Three years ago! PHP 5.3 is also supposed to be reaching end of life sometime this year. I don't think we should enable these sorts of bad practices.

imho, i believe we should retain a maintenance branch for anyone that wants to use it with php < php 5.3 if they need to. I understand that in some cases people cannot upgrade.

For best practice, security and other aspects, I would support making php 5.3 a minimum and continuing stable development in a php 5.3 and up branch.

It can't hurt. The current code is fairly stable, so if we're going to make sweeping changes anyways, why not save the current version as stable PHP 5.2 and down and continue with the changes and the latest features? We should shoot for PHP 5.4+, with the sunset of PHP 5.3 in mind.

---

By the way icedlava, it'd be nice to have a single place to have all the code that isn't yet in core but adds new features core doesn't have, can you put changes you've made up on GitHub or somewhere, that makes it easier to see what you've done, and from that how it can be merged with all the other stuff people are working on.