Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
PHP error without warning when logging is enabled - SOLVED
05-12-2022, 03:20 PM,
#11
RE: PHP error without warning when logging is enabled - SOLVED
I am still on the master branch (I was only asking if I should switch to the bug fixes branch, I will continue to follow the master branch).

I am confused why you recommend changing log severity level back to none. I thought the error was due to my not having a valid log file path in Setup => System Parameters => Path to log files. Do you think the fwrite will fail again if revert your change? (I am assuming the missing field data in the log is a seperate issue)
http://www.dalescott.net
Reply
05-12-2022, 10:21 PM, (This post was last modified: 05-13-2022, 01:44 PM by TurboPT.)
#12
RE: PHP error without warning when logging is enabled - SOLVED
Only recommended to avoid errors if you revert the change.

Feel free to keep the change as-is, if desired, though what is being logged is not very useful.

I'll add another comment to this thread after the commit is merged this weekend.
Reply
05-13-2022, 12:07 AM, (This post was last modified: 05-16-2022, 04:23 AM by dalescott.)
#13
RE: PHP error without warning when logging is enabled - SOLVED
Understood, thanks! :-) (I temporarily reverted the change just to prove to myself the fault still existed even with a valid file path configured).

I also updated the post title to remove SOLVED, which was premature of me (I was thinking the issue was only my enabling logging without configuring a valid log file path).
http://www.dalescott.net
Reply
05-16-2022, 07:34 AM, (This post was last modified: 05-16-2022, 07:42 AM by TurboPT.)
#14
RE: PHP error without warning when logging is enabled
The fix has been committed, so you should be able to pull the change. I also fixed a typo in one of the log severity options, so there will be a couple of files plus the related changelog updates.

Here's example logging testing the fix with various log levels set:
Code:
2022-05-14 08-05-32,SUCCESS Report,admin,System configuration updated
2022-05-14 08-05-55,INFORMATION Message,admin,System configuration updated
2022-05-14 08-05-05,SUCCESS Report,admin,System configuration updated
2022-05-14 08-05-37,SUCCESS Report,admin,System configuration updated
2022-05-14 08-05-22,SUCCESS Report,admin,System configuration updated
2022-05-15 04-05-52,ERROR Report,admin,The unit of measure can not be created because another with the same name already exists.
2022-05-15 04-05-31,WARNING Report,admin,The the system is in demo mode and the security model administration is disabled
2022-05-15 04-05-16,INFORMATION Message,admin,The system is not configured for picking lists. A configuration parameter is required where picking slips are required. Please consult your system administrator.

Thanks for reporting the issue!
Reply
05-18-2022, 05:14 AM,
#15
RE: PHP error without warning when logging is enabled
Thanks @TurbuPT! I pulled from master and found no issues in basic testing.
http://www.dalescott.net
Reply
05-18-2022, 11:50 AM,
#16
RE: PHP error without warning when logging is enabled - SOLVED
Thanks for the update!
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)