Pending 4.15.1 release - Printable Version +- webERP Forum (http://www.weberp.org/forum) +-- Forum: webERP Discussion (http://www.weberp.org/forum/forumdisplay.php?fid=1) +--- Forum: Project Admin (http://www.weberp.org/forum/forumdisplay.php?fid=11) +--- Thread: Pending 4.15.1 release (/showthread.php?tid=8210) |
RE: Pending 4.15.1 release - TimSchofield - 06-04-2019 Hi Paul, yes the release script will copy your data in it's entirety into the new demo data, so be careful that there is nothing in there you wouldn't want making public (your home address for instance might end up there). I will look at what you say about the DB upgrade code a bit later when I have more time. Tim RE: Pending 4.15.1 release - TurboPT - 06-05-2019 With the last release, it was based on a clean (fresh install) copy of 4.14.1 to run the 4.15 script to update the DB. (that is how I discovered that all of the tables were not created during install) I did that intentionally (and this time around too) to avoid any possible "dev garbage" of mine, so I'm not sure of the password difference, and don't think anything unusual crept into the last release. (I don't see any dev garbage within the insert statements) None of my general "dev passwords" worked either, so there's no telling what password is set. No worries, I'll ensure to update the reference, and test afterwards! Thanks for checking the DB thing whenever you get a chance. (seems the move makes sense based on code flow) RE: Pending 4.15.1 release - TimSchofield - 06-05-2019 Hi Paul, sorry for the delay I was ill yesterday so never got back in to look at this. I am not sure it matters where this code is does it? Once it reaches that point if the upgrade is needed it redirects to UpgradeDatabase.php and then the whole session.php script gets run anyway. Though I may be missing something as I am still recovering Tim RE: Pending 4.15.1 release - TurboPT - 06-06-2019 Tim, no worries on the delay for me -- whenever you have time. Well yes and no on the code location... Granted, it might not matter, but the "flow" of that handling was unexpected since the login was technically invalid. I would have expected: [Login] => [Invalid Login] Instead of: [Login] => [DB Update] => [No Session Error] (nothing about a bad login) So, rethinking the picture, even my suggested move may not be enough to achieve the invalid login first, before DB upgrade, as it should flow. This may be something to fix post-release? I won't dwell on it, only an observation during testing. (and would only take the DB Upgrade flow if admin, I believe) RE: Pending 4.15.1 release - TimSchofield - 06-07-2019 Hi Paul, in that case I would go for it. I certainly can't see any harm to it, and it looks as though you are right. You need to take a decision on the changes Bob has sent in another thread. Should they go in this release or the next? Tim RE: Pending 4.15.1 release - TurboPT - 06-10-2019 Another update: The release is nearly done, I hit merge conflicts on many of the language (.mo and .po) files late last night, that I'll try to resolve tomorrow. I did not realize the commit/update to the languate files early Sunday. After correcting the merge conflict, the release will be ready. Other than that, a test of a normal DB upgrade did fine. Also, two clean installs of both weberp and weberpdemo databases installed all tables. (161 tables) RE: Pending 4.15.1 release - TimSchofield - 06-10-2019 (06-10-2019, 02:32 PM)TurboPT Wrote: The release is nearly done, I hit merge conflicts on many of the language (.mo and .po) files late last night, that I'll try to resolve tomorrow. Paul, these conflicts worry me they shouldn't be happening. Rafael updated the translation files just a short time ago. I think this is a consequence of what I mentioned before about him using slightly different commands to create the files now. I just worry you are bout to overwrite his work. Tim RE: Pending 4.15.1 release - TurboPT - 06-10-2019 I agree, and I'll keep Raphael's changes. Most of what I saw were date/time diffs (between his run, and the run I did from make_release the day before), but there were some others. It is curious, though, that a script Raphael sent me awhile back for his languages build seems to be the same as what is done in make_release, as far as the command, options, and directories processed. I'll take a closer look between the two, after release, to align any differences. RE: Pending 4.15.1 release - TimSchofield - 06-11-2019 To be honest the intricacies of gettext are a bit of a mystery to me. I just have this memory of the discussion with Rafael, and was concerned that whatever he did as a result of his work on it was going to end up being lost. I agree with you that leaving his files in place is best, as I am pretty sure no new strings got added after his last update. Tim RE: Pending 4.15.1 release - TurboPT - 06-12-2019 Another update: I emailed Raphael tonight about the language build differences. Turns out the diffs are many (about 30+ per file, at the same general places in all files), not just simple dates as originally perceived. The differences are easy and we should be able to align the differences between the scripts so that the generated output is the same.
So, between the latter and the other 2 items, are what comprise the differences. So to recap:
|