webERP Forum
Clone Invoice - Printable Version

+- webERP Forum (http://www.weberp.org/forum)
+-- Forum: webERP Discussion (/forumdisplay.php?fid=1)
+--- Forum: Feature Requests (/forumdisplay.php?fid=5)
+--- Thread: Clone Invoice (/showthread.php?tid=8169)

Pages: 1 2


RE: Clone Invoice - falkoner - 06-18-2018 11:43 PM

This needs more thinking about. It is possible for instance to have invoices that contain both goods received and general ledger codes within the same invoice. So should we then just clone the GL parts?
A few years ago a customer asked for a default GL code by supplier. So for instance if you went to create an invoice for your electricity supplier it defaulted to the electricity GL account and all you had to do was fill in the date reference and the amount. Would thiss give you what you want?

Tim


RE: Clone Invoice - VortecCPI - 06-19-2018 06:11 AM

That sounds to be a very useful feature and perhaps exactly what I need.


RE: Clone Invoice - falkoner - 06-19-2018 06:17 AM

Then let me look tomorrow at transferring that code over


RE: Clone Invoice - VortecCPI - 06-19-2018 07:17 AM

Thank you so much Tim!


RE: Clone Invoice - falkoner - 06-19-2018 07:25 AM

In fact it was fairly easy to apply my changes and sleeping is hard in the heat Smile so I have committed them here:

https://github.com/timschofield/webERP-svn/commit/01898eef8f8c1564562fda45b76477168d779379

It just needs someone to pull them over.

Note there is a database update needs applying. I have put it in a new file sql/mysql/upgrade4.15-4.15.1.sql which may be the wrong name, who knows!

Tim


RE: Clone Invoice - TurboPT - 06-19-2018 01:11 PM

Thanks Tim! (Yes, that would be the correct name for the next DB update file)

Those changes committed to: HEAD, and to branch: webERP_release_4.15.1.


RE: Clone Invoice - falkoner - 06-19-2018 06:01 PM

Thanks Paul.

I noticed when I did these changes that Phil has two virtually identical input forms in Suppliers.php one for a new supplier and one for editing an existing supplier. This is confusing as any change to the form such as this one has to be coded twice. It is also inconsistent with the way the rest of webERP works. They should really be amalgamated.

Also years ago someone requested on this forum for a default shipper by supplier. It got rejected at the time for reasons I didn't understand so I implemented it in my code. It is near identical change to the default GL code one so I could easily add it if you want.

Tim


RE: Clone Invoice - VortecCPI - 06-19-2018 09:12 PM

Thank you so much Tim and Paul!


RE: Clone Invoice - TurboPT - 06-20-2018 10:19 AM

Sure, Tim, we can add the other file that you mentioned.


RE: Clone Invoice - falkoner - 06-20-2018 05:58 PM

I have added in the default shipper code here https://github.com/timschofield/webERP-svn/commit/8f8ea3d9ca91a943ebe70cee5008d10c29435b5d

I don't have the time or inclination to fix up the forms but it doesn't affect the performance just makes the code look shabby.

Tim