webERP Forum
PO Items - Table Header Sort - Bad - Printable Version

+- webERP Forum (http://www.weberp.org/forum)
+-- Forum: webERP Discussion (/forumdisplay.php?fid=1)
+--- Forum: Problems / Bugs? (/forumdisplay.php?fid=8)
+--- Thread: PO Items - Table Header Sort - Bad (/showthread.php?tid=8097)



PO Items - Table Header Sort - Bad - VortecCPI - 02-15-2018 06:54 AM

PO_Items.php

I inadvertently clicked on the table header and it tried to sort and made a mess. Not good!


RE: PO Items - Table Header Sort - Bad - falkoner - 02-15-2018 07:41 AM

There is an update to the table sorting routine that is awaiting committing to svn.

Tim


RE: PO Items - Table Header Sort - Bad - TurboPT - 02-17-2018 02:28 PM

Tim/Paul: I'm looking into the new sorting "scope" now...

Paul, has something possibly changed?
Back at this post, you claimed the sorting was ok after adding <tbody>; however, there could of course be other sorting issues.
Also, in Tim's repository, I noticed that only the first two columns (item code, description) are set as sortable, the others (beyond those two, that have a sort indicator) are not.


RE: PO Items - Table Header Sort - Bad - falkoner - 02-17-2018 10:14 PM

I try and restrict sorting to just those columns where it would make sense to want to sort, though of course that is a subjective opinion, and others may see a point to sorting where I don't Smile


RE: PO Items - Table Header Sort - Bad - TurboPT - 02-18-2018 02:13 PM

(02-17-2018 10:14 PM)falkoner Wrote:  I try and restrict sorting to just those columns where it would make sense to want to sort, though of course that is a subjective opinion...

Yep, true to that, but of course, it is a simple matter to add (or remove) the sorting need as desired. Definitely good for overall 'flexibility'.
As much as one might like, or none at all!