+- webERP Forum (http://www.weberp.org/forum)
+-- Forum: webERP Discussion (http://www.weberp.org/forum/forumdisplay.php?fid=1)
+--- Forum: Problems / Bugs? (http://www.weberp.org/forum/forumdisplay.php?fid=8)
+--- Thread: Lot numbers not printed in landscape (/showthread.php?tid=8065)
Lot numbers not printed in landscape - HDeriauFF - 01-28-2018
I just understood why I was confused about no longer seeing my lot numbers on my invoices:
- when your system parameters are set up to portrait, lot numbers are displayed on the invoice as expected.
- when your system parameters are set up to landscape. lot numbers are no longer displayed.
Thank you for confirming you are seeing the same.
RE: Lot numbers not printed in landscape - TurboPT - 01-28-2018
Yep, it appears that the lot number handling was never applied to the landscape file.
I'm comparing to the portrait copy now, and once I can get a merge on that together, I'll post a file copy to test/try.
RE: Lot numbers not printed in landscape - VortecCPI - 01-28-2018
Wow. I did not notice this. Thank you so much for pointing it out!
RE: Lot numbers not printed in landscape - HDeriauFF - 01-29-2018
(01-28-2018, 03:51 PM)TurboPT Wrote: Yep, it appears that the lot number handling was never applied to the landscape file.
I'm comparing to the portrait copy now, and once I can get a merge on that together, I'll post a file copy to test/try.
Thank you!
RE: Lot numbers not printed in landscape - TimSchofield - 01-29-2018
We should only have the one script really and use the xml file to determine the orientation then we don't have to maintain 2 nearly identical files
RE: Lot numbers not printed in landscape - TurboPT - 01-29-2018
Tim, yes I absolutely agree to that, as the PDF calculations/handling does differ between the two files.
The same can be said for some other PDF files too.
In my mind, I like to get to a "near identical" format, so that it's easier to see/visualize the abstraction/refactoring that can be done. Having worked with Javascript for awhile, I prefer JSON over XML, but I'm ok with either format.
RE: Lot numbers not printed in landscape - TimSchofield - 01-29-2018
I am not fixated on the idea of xml if you want to do the work to move it to json you would hear no complaints from me
RE: Lot numbers not printed in landscape - TurboPT - 01-29-2018
HDeriauFF,
Try the attached file to see if that helps the situation, or not. The 'Print Preview' option is now available with this script too.
With my basic testing of one item with an 'Invoice' PDF and the Preview were both ok, however, I do not have any controlled items for a full test.
Although I did get an error checking the 'Credit Note' path, I may be missing something for the credit side to work (as a note at the top of the page says), but the query syntax output after error was ok.
Also, if you happen to have a transaction that spans 2 or 3 pages would be worth a test too to ensure no artifacts.
Let us know if you find any issues.
NOTE: I'd first save (or backup) the current file before replacing!
RE: Lot numbers not printed in landscape - VortecCPI - 01-29-2018
Wow. Lots of differences between the two files in 4.14.1.
Looks like you have covered all those differences for us.
I see there has been some changes to authority we need to check.
17/10/25 Exson: Fixed the salesman authority problem in PrintCustTrans.php.
RE: Lot numbers not printed in landscape - VortecCPI - 01-30-2018
I also just noticed we have no due date on our invoices... Nor in preview via PrintCustTrans.php