webERP Forum
ImportBankTrans Error - Printable Version

+- webERP Forum (http://www.weberp.org/forum)
+-- Forum: webERP Discussion (/forumdisplay.php?fid=1)
+--- Forum: Problems / Bugs? (/forumdisplay.php?fid=8)
+--- Thread: ImportBankTrans Error (/showthread.php?tid=8062)



ImportBankTrans Error - VortecCPI - 01-27-2018 01:45 AM

includes/DefineImportBankTrans.php

Line 63 has one too many opening parenthesis:
self::__construct(($ValueDate, $Amount);

Should be this:
self::__construct($ValueDate, $Amount);


RE: ImportBankTrans Error - TurboPT - 01-27-2018 05:31 AM

Hmmm, that is already fixed in SVN. In fact, I applied that change in April last year! Wink

Not sure how you might have it the old way?

Oh well, good to know that it's already covered.


RE: ImportBankTrans Error - TurboPT - 01-27-2018 05:46 AM

Tim, on a side note, at the top of the bank trans class file, the SVN version/timestamp line is present, but has not updated since 2009??

I've noted too, that in several other files that line is not updating. Is there something special with the format to make it work?

I search around sourceforge a bit, but I could not find a reference about that line, or my search terms were not finding the information.


RE: ImportBankTrans Error - falkoner - 01-27-2018 06:03 AM

Now then, that is stretching my memory a bit. Big Grin
It has to do with keyword substitution (http://svnbook.red-bean.com/en/1.7/svn.advanced.props.special.keywords.html), Nicholas Lee set this up when we moved to Subversion from CVS many years ago. As I remember the string

$Id$

needs to be inserted at the beginning of the file and then subversion will substitute Id with the details of that revision. Looking at it that needs to be within a comment so

/* $Id$ */

but that's about as far as I remember. These days I only use Git as it does so much more and so much better so my subversion knowledge is sketchy at best.

Tim


RE: ImportBankTrans Error - TurboPT - 01-27-2018 06:08 AM

Unfortunately, that link is dead now. Sad

Though that does make me think to look at SVN info instead of scouring sourceforge!

I'll carefully compare the files that are working against those that are not as well to see if there's any difference.


RE: ImportBankTrans Error - falkoner - 01-27-2018 06:12 AM

Does this link work now?

http://svnbook.red-bean.com/en/1.7/svn.advanced.props.special.keywords.html


RE: ImportBankTrans Error - TurboPT - 01-27-2018 06:13 AM

The link is not dead, there are extra chars at the end of the link in post 4.

Yes, it works now, thanks!