+- webERP Forum (http://www.weberp.org/forum)
+-- Forum: webERP Discussion (http://www.weberp.org/forum/forumdisplay.php?fid=1)
+--- Forum: Problems / Bugs? (http://www.weberp.org/forum/forumdisplay.php?fid=8)
+--- Thread: Contract - Retrieval Issue (/showthread.php?tid=8000)
RE: Contract - Retrieval Issue - VortecCPI - 01-04-2018
(01-04-2018, 06:03 AM)TurboPT Wrote: Tim, yep the second change in that image.
That has been applied, but I don't know if the first change in that image is still necessary. (Paul B.?)
I loaded the file from SVN and it works as expected so all seems well.
RE: Contract - Retrieval Issue - VortecCPI - 01-06-2018
We do still have an issue in that the list table header shows "Print Quote" columns for a Sales Order.
Looking into it right now...
RE: Contract - Retrieval Issue - TurboPT - 01-06-2018
From the same file? ... Ok, looking too...
RE: Contract - Retrieval Issue - VortecCPI - 01-06-2018
I had to add this back at line 655:
$_POST['Quotations']='Orders_Only';
I apologize because I believe you asked me about this in an earlier post.
RE: Contract - Retrieval Issue - TurboPT - 01-06-2018
No worries! ... What are the exact navigation steps to get to that point?
I'm curious as to how the handling at lines 32-37 might not have a GET/POST on 'Quotations' with that value ... unless perhaps line 36 should default to 'Orders_Only' (as long as this change does not cause other trouble, of course) instead of an empty string?
I'm still investigating the overall flow... though if I don't get any better 'picture', I will put that change where you mentioned.
RE: Contract - Retrieval Issue - VortecCPI - 01-06-2018
Main Menu > Sales > Sales Orders/Confirmations
When the page loads the table shows columns for a Quotation:
[attachment=671]
Click the "Search" button and the table shows properly:
[attachment=672]
I don't know if my hack is right but it appears to work. I hate to be lazy with such a hack but we have our first order and I have to get moving!
I wonder how many are using the Quotation feature in webERP? I changed the language file to read "Confirmation" as we may use it to create a Sales Confirmation and then then convert it to a Sales Order for fulfillment. All our Proposals/Quotations are handled via SuiteCRM.
RE: Contract - Retrieval Issue - TimSchofield - 01-06-2018
The section at line 650 (approx) should be as follows:
if ($_POST['Quotations'] == 'Orders_Only') {
$Quotations = 0;
} elseif ($_POST['Quotations'] == 'Quotes_Only') {
$Quotations = 1;
} elseif ($_POST['Quotations'] == 'Overdue_Only') {
$Quotations = "0 AND itemdue<CURRENT_DATE";
} else {
$Quotations = 0;
$_POST['Quotations'] = 'Orders_Only';
}
Thanks
Tim
RE: Contract - Retrieval Issue - TurboPT - 01-07-2018
Change committed to SVN.
RE: Contract - Retrieval Issue - TimSchofield - 01-07-2018
Thanks Paul.
Just a note. In the world of open source software it is considered courteous to attribute code to the person who wrote it ☺
Tim
RE: Contract - Retrieval Issue - VortecCPI - 01-07-2018
(01-07-2018, 12:42 AM)falkoner Wrote: Thanks Paul.
Just a note. In the world of open source software it is considered courteous to attribute code to the person who wrote it ☺
Tim
Thank you Tim but as I am such a PHP and webERP novice I am never sure if my fixes are fixes or just hacks. I am always happy and comforted when you guys look at it and verify it and/or make it right.
As always, thank you all for your help in this matter!