webERP Forum
Spelling mistake on CodingConventions - Printable Version

+- webERP Forum (http://www.weberp.org/forum)
+-- Forum: webERP Discussion (/forumdisplay.php?fid=1)
+--- Forum: Problems / Bugs? (/forumdisplay.php?fid=8)
+--- Thread: Spelling mistake on CodingConventions (/showthread.php?tid=2341)



Spelling mistake on CodingConventions - mastertrait - 11-18-2014 07:45 PM

Not sure if intentional, if it was its amusing Angel

'Whenever a statement block is used code within the block should be one tab indented. Indenting code correctly is critical to avoid logic errors and to imrpove readability.'


RE: Spelling mistake on CodingConventions - mastertrait - 11-18-2014 07:47 PM

Oh also line after;
Function defintions should follow the same conventions.

Again if on purpose Angel Angel


RE: Spelling mistake on CodingConventions - mastertrait - 11-18-2014 08:17 PM

"The standard message function prnMsg should always be used for all messages to be echo'ed to the screen"

Should be echoed, but is easier to read as it is.

"(currently only includes/ConnectDB_mysql.inc exists - 2007 - ConnectDB_postgres.inc was depreciated but could easily be revived if we stick with this convention)"

Deprecated. (Guess it was depreciated to get deprecated Wink )

" If the data is not common accross all rows then it probably belongs in a separate table."

Across.

"SQL kywords should be capitalised as above "

Keywords.


RE: Spelling mistake on CodingConventions - phil - 11-19-2014 08:21 AM

Thanks for the proof reading ... yep some good fun cock-ups in there!


RE: Spelling mistake on CodingConventions - mastertrait - 11-19-2014 11:51 PM

I'm integrating your system into the company I work for so if you’d like I can regularly post typos (Going to be reading alot)? Only reason I signed up to your forums, system is easy to implement/customize/well documented,

Good Job, throw me an email on the email I signed up with, so I don't have to keep resetting password on emails Smile!


RE: Spelling mistake on CodingConventions - phil - 11-20-2014 07:00 PM

Just fixed and uploaded ... thanks :-)