webERP Forum
Potential footer change question - Printable Version

+- webERP Forum (http://www.weberp.org/forum)
+-- Forum: webERP Discussion (/forumdisplay.php?fid=1)
+--- Forum: Development Discussion & Specification (/forumdisplay.php?fid=10)
+--- Thread: Potential footer change question (/showthread.php?tid=2134)



Potential footer change question - TurboPT - 03-02-2014 08:35 AM

The question concerns swapping two divs in the footer before commit.
More info, below.

I have a minor footer change that would swap the date/time and version div positions. This would have a trivial impact to most themes, EXCEPT for Gel & Silverwolf as the styles are handled differently for these two.

Swapping those divs will simplify some CSS specifically for the Gel & Silverwolf themes, but for all other themes, the two divs will simply have vertically swapped position [date/time above the version] where they already appear at the footer's far left side.

So, would this swap be ok to commit?

If desired, I could attach a patch here if anyone would like to preview before commit.


RE: Potential footer change question - phil - 03-02-2014 06:36 PM

Hi Paul,
As long as all themes that would be damaged are fixed so something sensible results - then please go for it.


RE: Potential footer change question - TurboPT - 03-03-2014 09:24 AM

(03-02-2014 06:36 PM)phil Wrote:  Hi Paul,
As long as all themes that would be damaged are fixed so something sensible results - then please go for it.
Done. I'm not sure about the "damaged" reference, but hopefully the committed results are an improvement.
[the change also corrected the date/time div that was hidden (out of view) for the gel theme]

If there's some other tweak[s] to be done in that area, let me know!


RE: Potential footer change question - phil - 03-03-2014 11:27 AM

Well by "damaged" I just meant that if the display of those other themes were adversely affected by the change - then the necessary changes to those themes should also be looked at. Sounds like that was a non-issue in any event.