webERP Forum

Full Version: Table deliverynotes is orphaned?
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
I've not yet been able to fully dig into when the deliverynotes table became orphaned, but there are no longer any code references to the table. I noted this table missing before the 4.15.2 release when pre-testing clean installs.

This repository search only finds references in the sql/mysql/ path, from when the table was first created back in v3.11, and other version updates since then, but nowhere else.

So, what should we do?
  1. Restore the table and related references?
  2. Add a drop table with the next release? (or make a release note so that users can do it themselves? ... so that we don't cause any data loss)
  3. Something else???
Anyway, if anyone may already have some historical knowledge relative to this table, please add a comment, whether good or bad, so that we can determine the best resolve.
I have done a thourough search of the history, and I can't find that table ever being used in the code. It was created but never used. So unless anybody knows different I would suggest dropping the table.

The only proviso would be if somebody has written custom code that uses that table, but I think in this case the onus is on them to ensure updates don't affect their custom code.

Ok then, in the next day or two, I'll start a new migrate SQL file for the next version with the table drop.

Obviously, the drop can be removed should any other insights about this table come forward.
Paul, rather than start a new SQL file, I would rather if we can agree on it, we move to the new DB upgrade system I have outlined here:

I have written the code for it, you can find it here:

Once it's tested, it would just be a matter of sending a pull request to your repository.

Oh, ok, I'll have to check that out. I was about to add a link for the new file commit.

No problem reverting what I've created.
Tim, I've created a pull request that reverts that SQL file. (and related changelog entry)
Thanks Paul, If you are OK with my new DB upgrade system, can I suggest you create a v5.0 branch, and then I can send a pull request?

Yes, the DB update looks good to me. I have created branch weberp_version5.

The only tangent question I have ... would we like to see those 4 UpgradeDB* files moved into class/OO form at some point? I don't mind tackling at a later time, if so.

After I pull later, I'll give it a trial run for my own curiosity and interest.
Thanks Paul. I have no problem moving those files there.

I will do the pull request on Sunday - not sure my wife will want me going this stuff on Christmas day ?
Mine either, very likely ... it can wait until next week if needed, enjoy the holiday weekend! Smile
Pages: 1 2