webERP Forum

(10-02-2020, 12:18 AM)HDeriauFF Wrote: [ -> ]Phil, any feedback on the solution I submitted?

falkoner Wrote:

HDeriauFF Wrote:Phil, any feedback on the solution I submitted?

I have been playing around with this, and have the attached version working (the changes may be the same as yours in which case I apologise).



This *seems* to work on all scenarios but would appreciate your testing.

A couple of general comments that arose when I looked into this:

1 I thought a decision had been taken a while back to get rid of zero dates as they there are some sql-mode settings in mysql that prohibit them.
2 We should really get rid of all the .inc files and replace them with .php. This was done with some files but not all.

Thanks
Tim


the GetPrice file you provided works for me with the following scenarios:

[ul]
[li]Product with two [same customer] special prices, both end dates in the past[/li]
[li]Product with two [same customer] special prices, one end date in the past, the other one at zero[/li]
[li]Product with two [different customers] special prices,both end dates in the past[/li]
[li]Product with two [different customers] special prices, one end date in the past, the other one at zero[/li]
[/ul]
Thanks!