webERP Forum

#1

since you are in favor of fixing this

Would like to confirm can we stick by this format?
the change is not just matching up colums but it also propose to use tags like thead, th, tbody, tfoot where the column titles are repeated again in the tfoot

<table class="selected">
<thead>
<tr>
<th>Col1</th>
<th>Col2</th>
<th>Col3</th>
<th>Col4</th>
<th colspan="2">Actions</th>
</tr>
</thead>
<tbody>
<tr>
<td>Data</td>
<td>Data</td>
<td>Data</td>
<td>Data</td>
<td>Edit</td>
<td>Delete</td>
</tr>
</tbody>
<tfoot>
<tr>
<th>Col1</th>
<th>Col2</th>
<th>Col3</th>
<th>Col4</th>
<th colspan="2">Actions</th>
</tr>
</tfoot>
</table>


#2
I am also in favor in code readability and neatness

please take a look at the code again

-----------------------------------------------------------
echo '<div>
<h3>' . $title . '</h3>
</div>';
------------------------------------------------------------
v/s
------------------------------------------------------------
<div>
<h3><?php echo $title?></h3>
</div>
-----------------------------------------------------

Really the second method is much easier and less prone to error there are no [;] , [.] and ['] to keep track of, the php parts only serve to echo variables. its basically html with php as the variables

so long as there is anything dynamic, just copy paste this structure <?php echo _('title')?>

#1
Yes I can see the usefulness of having the header repeated at the bottom - although it could be confusing also where there is no data below it.
If
<thead>
<tbody>
<tfoot>
etc are all required as best practise then these are worthy additions - and would give more scope to the theme css

#2
I prefer the first - there is no <?php ?> in it. In webERP scripts mostly there is just a single <?php at the start and a single ?> at the end!!
I would have it indented though:

Shouldn't there be a ; after echo $title;


I strongly prefer to stay inside the php interpretor than continually go in and out.

I prefer the readability of the :


over


but really the difference is minimal - and certainly NOT worth putting any additional effort into IMHO

in a single line, single statement in php <?php echo $title?> the ; isnt required.

Alright, so when can we get started with proposal #1

how can we coordinate this in a way that does not override each others work

(09-19-2012, 02:06 AM)hindraj Wrote: [ -> ].. ..

PS: Please don't give up!

Best regards,
Hindra Joshua

Hi Hindra

I am new to webERP but I'd followed your posts and I really appreciate you. I believe that your idea about UI is as important as the other aspects of this great software.
Thanks for your nice designs and your assiduity.

Would you please let me know how can I download the latest RTL theme for webERP 4.10 ?

Regards
Farbod

I suppose we possibly will use this for footer and header and find the proper solution of css for the additional themes lacking too much of a problem.

Really appreciate it! thank you alot!
สุดยอดเว็บไซด์คาสิโน บาคาร่าออนไลน์ โป๊กเกอร์ สล๊อตออนไลน์ พร้อมลุ้นแจ๊กพอตกว่าหนึ่งล้านบาท สมัคร บาคาร่าออนไลน์