webERP Forum

Full Version: Blank lines at end of scripts
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
The rule is matching tags and no newline at the end of files.
(02-26-2014, 05:51 PM)phil Wrote: [ -> ]The rule is matching tags and no newline at the end of files.

Hi Phil, for some time now you have been adding new lines at the end of files. here you add a new line to the end of includes/PDFStockCheckPageHeader.inc

https://sourceforge.net/p/web-erp/code/6578/#diff-1

here to AddCustomerNotes.php and AddCustomerTypeNotes.php

https://sourceforge.net/p/web-erp/code/6575/#diff-1

and that is just your last couple of commits. It goes back months. We have spoken before about the need to apply the rules to everyone, and not just those you are trying to force off the project.

Tim
Thanks Tim - I will review and fix - might be sommat to do with settings to geany?

sure enough
[attachment=262]
(02-26-2014, 07:06 PM)phil Wrote: [ -> ]Thanks Tim - I will review and fix - might be sommat to do with settings to geany?

sure enough

Thats what I suggested it would be on the 15th Feb

Tim
Pages: 1 2