webERP Forum

Full Version: Select Order Items - Why Print "2"?
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
SelectOrderItems.php

Why are we printing $ShowDiscountGP ("2") at the bottom of the Line Items table?

See line 1453:

PHP Code:
        echo '<tr class="EvenTableRows">
                <td class="number" colspan="6"><b>' 
_('TOTAL Excl Tax/Freight') . '</b></td>
                <td colspan="' 
$varColSpan '" class="number"><b>' $DisplayTotal '</b></td>
                <td colspan="2">' 
$ShowDiscountGP '&nbsp;</td>
            </tr>
            </table>'


[attachment=685]
Yes, that definitely seems strange to be displayed that way, as that value is used with 'colspan' value calculations.

Comparing repositories, I'll remove that cell reference, as it obviously serves no real purpose, and could cause confusion with the price value.
(likely a long left-over debug thing?)

Along with that change, in the same file, I'm replacing a hard-coded style with an existing CSS class. This will avoid the burgundy/maroon background with black text which makes the columns hard to read. Now the style will match the CSS which can be tweaked as necessary based on the theme.
Changes committed to SVN.
I spotted similar hard coded CSS (style="background-color:#800000") in SupplierInvoice.php and CounterSales.php.

Andy.
(01-25-2018 03:29 AM)afcouling Wrote: [ -> ]I spotted similar hard coded CSS (style="background-color:#800000") in SupplierInvoice.php and CounterSales.php.

Andy.

Ok, I'll cover those areas those too!
Thanks Andy, changes committed to SVN.
Thank you all!
One more small comment on this...

The Stock/Inventory table does not sort when clicking on headers so we need to add <tbody> and <table class="selection"> to enable it.

My own file attached for reference and checking...
Are you talking about the Stocks.php script, or a sub-table in some other script?
Sorry about ambiguity. Please see post #8 above.
Pages: 1 2
Reference URL's